Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support: migrated to supportconfig.rc #1055

Merged
merged 1 commit into from
Dec 22, 2023
Merged

support: migrated to supportconfig.rc #1055

merged 1 commit into from
Dec 22, 2023

Conversation

mssola
Copy link
Contributor

@mssola mssola commented Dec 14, 2023

Description

ALP will not support the deprecated scplugin.rc framework. This commit, then, migrates our support script to work with supportconfig.rc.

This patch has been originally contributed by Jason Record on the linked Bugzilla entry.

Fixes bsc#1216389

How to demo

NOTE: I have tested the following on a SLES15 SP4 machine. It would be extra dope if you could test it on other environments such as SLES12 LTSS.

The easiest route is to either install RMT on a machine, or re-use an existing installation. Thus, before any of this, ensure that rmt-server and supportutils are installed on your system. Then just copy the support/rmt file from this PR into /usr/lib/supportconfig/plugins and give it executable rights (as root):

# cp <path>/support/rmt /usr/lib/supportconfig/plugins/
# chmod +x /usr/lib/supportconfig/plugins/rmt

To ensure that the installation works, run supportconfig like so:

# supportconfig -F

There should be prmt (the 'p' is just a prefix for 'plugin'). You could try running just this plugin:

# supportconfig -i prmt

On the generated tarball, make sure that there is a file named output-rmt.txt with the results from this run.

Note that stuff like passwords have been blanked out by supportconfig.rc, this is to be expected. As a reference, this is the configuration as shown from my machine:

database:
  host: localhost
  database: rmt
  username: rmt
  password: *REMOVED BY SUPPORTCONFIG*
  adapter: mysql2
  encoding: utf8
  timeout: 5000
  pool: 5

Change Type

Please select the correct option.

  • Bug Fix (a non-breaking change which fixes an issue)
  • New Feature (a non-breaking change which adds new functionality)
  • Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

  • I have verified that my code follows RMT's coding standards with rubocop.
  • I have reviewed my own code and believe that it's ready for an external review.
  • I have provided comments for any hard-to-understand code.
  • I have documented the MANUAL.md file with any changes to the user experience.
  • RMT's test coverage remains at 100%.
  • If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Other Notes

Please use this space to provide notes or thoughts to the team, such as tips on how to review/demo your changes.

@mssola
Copy link
Contributor Author

mssola commented Dec 14, 2023

@ngetahun ngetahun self-requested a review December 18, 2023 12:49
support/rmt Outdated Show resolved Hide resolved
ALP will not support the deprecated scplugin.rc framework. This commit,
then, migrates our support script to work with supportconfig.rc.

This patch has been originally contributed by Jason Record on the linked
Bugzilla entry.

Fixes bsc#1216389

Signed-off-by: Miquel Sabaté Solà <[email protected]>
@SUSE SUSE deleted a comment from suse-tests-pass Dec 18, 2023
@suse-tests-pass
Copy link
Collaborator

Well Done! Your tests are still passing.
https://ci.suse.de/job/scc-RMT-integration-tests/348776/console
If the given link has expired,you can force a Prophet rerun by just deleting this comment. (Merged a72344d into 803d2b2)

Copy link
Contributor

@ngetahun ngetahun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mssola mssola merged commit 98f1142 into master Dec 22, 2023
3 checks passed
@mssola mssola deleted the supportconfig.rc branch December 22, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants